Skip to content

feat: Set LAR as False #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat: Set LAR as False #1883

merged 1 commit into from
Jul 21, 2023

Conversation

surbhigarg92
Copy link
Contributor

No description provided.

@surbhigarg92 surbhigarg92 requested review from a team as code owners July 21, 2023 16:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jul 21, 2023
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit ed510e8 into googleapis:main Jul 21, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 21, 2023
@release-please release-please bot mentioned this pull request Jul 21, 2023
Merged
surbhigarg92 added a commit to surbhigarg92/nodejs-spanner that referenced this pull request Aug 4, 2023
@surbhigarg92
Revert "feat: Set LAR as False (googleapis#1883)"
80a1a70 
This reverts commit ed510e8.
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 4, 2023
@surbhigarg92
Revert "feat: Set LAR as False (#1883)" (#1891)
6852d99 
BEGIN_COMMIT_OVERRIDE
feat: Enable leader aware routing by default. This update contains performance optimisations that will reduce the latency of read/write transactions that originate from a region other than the default leader region.
END_COMMIT_OVERRIDE
@surbhigarg92 surbhigarg92 deleted the lar_off branch October 23, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surbhigarg92 @rajatbhatta