Enable -Werror=conditional-uninitialized if available #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix two trivial local violations - initialized to the empty or failing value, respectively. Note, in the current code these are false positives as the called functions do set the value in all cases, but these initializations remove the reliance on that external property.
|
Very good! Thanks for fixing this @Empact! Would be really nice to get rid of these warnings when building Bitcoin Core! |
maochongxin
pushed a commit
to maochongxin/leveldb
that referenced
this pull request
Jul 21, 2022
…CacheSizes() (google#775) - On qnx platform, cpu and cache info is stored in a syspage struct which is different from other OS platform. - The fix has been verified on an aarch64 target running qnx 7.0. Fixes google#774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix two trivial local violations - initialized to the empty or
failing value.
Note, in the current code these are false positives as the called
functions do set the value in all cases, but these initializations
remove the reliance on that external property, and enable
automatic detections of future violations.
Motivated by a desire to enable this warning in a project
that builds leveldb as a dependency.