Skip to content

Return new http.Client when nil passed to NewClient #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2019
Merged

Return new http.Client when nil passed to NewClient #1178

merged 2 commits into from
May 30, 2019

Conversation

gmlewis
Copy link
Contributor

@gmlewis gmlewis commented May 26, 2019

Fixes #1173.

Reviewers: can you think of any negative impacts this change might have on users of this package?

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 26, 2019
@gmlewis gmlewis changed the title Issue 1173 default client Return new http.Client when nil passed to NewClient May 26, 2019
@codecov
Copy link

codecov bot commented May 26, 2019 •
edited
Loading

Codecov Report

Merging #1178 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1178   +/-   ##
======================================
  Coverage    70.2%   70.2%           
======================================
  Files          84      84           
  Lines        5844    5844           
======================================
  Hits         4103    4103           
  Misses        954     954           
  Partials      787     787
Impacted Files Coverage Δ
github/github.go 87.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9010303...5182c72. Read the comment docs.

@gmlewis gmlewis requested a review from gauntface May 26, 2019 21:26
gauntface
gauntface approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me and I can't think of any negative consequences.

@gmlewis
Copy link
Contributor Author

gmlewis commented May 30, 2019

Thank you, @gauntface!
Merging.

@gmlewis gmlewis merged commit 6264c79 into google:master May 30, 2019
@gmlewis gmlewis deleted the issue-1173-default-client branch May 30, 2019 02:05
@suhaibmujahid suhaibmujahid mentioned this pull request Mar 19, 2020
Merged
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@gmlewis
Return new http.Client when nil passed to NewClient (google#1178)
393852c 
Fixes google#1173.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gauntface gauntface gauntface approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsafe concurrent modification of http.DefaultClient
3 participants
@gmlewis @gauntface @googlebot