Skip to content

[BSv5] Navbar: add inner container + cleanup #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

[BSv5] Navbar: add inner container + cleanup #1422

merged 1 commit into from
Feb 22, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 15, 2023 •
edited
Loading

Preview: https://deploy-preview-1422--docsydocs.netlify.app

Screenshots

Navbar scrolling still works on mobile:

image
image
image
image

@chalin chalin force-pushed the chalin-im-nav-2023-02-14 branch from 1835152 to 301652f Compare February 15, 2023 21:19
@chalin chalin requested review from deining and geriom February 15, 2023 21:21
@chalin chalin mentioned this pull request Feb 15, 2023
Closed
50 tasks
deining
deining approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geriom
geriom approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@chalin
Copy link
Contributor Author

chalin commented Feb 22, 2023

Thanks for the reviews all!

@chalin chalin force-pushed the chalin-im-nav-2023-02-14 branch from 301652f to 2f9708e Compare February 22, 2023 22:51
@chalin chalin merged commit 02d0e25 into google:main Feb 22, 2023
@chalin chalin deleted the chalin-im-nav-2023-02-14 branch February 22, 2023 22:52
@chalin chalin mentioned this pull request May 26, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriom geriom geriom approved these changes

+1 more reviewer

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @deining @geriom