-
Notifications
You must be signed in to change notification settings - Fork 945
Description
Bootstrap 5 has some changes that seem to break Docsy site builds #304 #464.
(Edit: @chalin)
Info: the last BSv4 build
A link to the last edition of the User Guide that was build with BSv4: https://deploy-preview-1356--docsydocs.netlify.app. This link was taken from the last PR/commit of v0.6.x.
Prep
- Blog layout: streamline and fix styling RSS button #1193
- Reformat SCSS sources using Prettier #1454
- Delete duplicate mixin definitions #1458
Tasks
All of the section headings below that are hyperlinks, link to a section of the Bootstrap 5.2 migration guide of the corresponding name. A GitHub user name on a section or subsection heading declares that person as taking responsibility for making the corresponding changes to Docsy.
✅ Dependencies - @chalin
- BS dropped jQuery, but it is still used if present. We'll handle this later via
Drop jQuery #1436 - Upgrade to Popper v2 is done automatically thanks to Scripts: get Popper from Bootstrap bundle #1268
- [BSv5] Docsy depencendies: bump _rfs.scss to bootstrap version 5.2.3 #1372
- [BSv5]: make docsy point to latest version of dependencies #1374
✅ Sass - @chalin
- Renamed
color-yiq()
function and related variables tocolor-contrast()
, etc. For details, see corresponding Sass entry: -
⚠️ media-breakpoint-down()
change argument to be next breakpoint of higher value
[BSv5] Adjust media-breakpoint-down() argument #1367
Projects will have to make a similar change to their styles. $enable-print-styles
N/Acolor()
etc. N/Acolor-level
etc. N/Areduced-motion
etc. N/A- Gradient related changes:
bg-gradient-variant()
is gone, etc. - Removed previously deprecated mixins. N/A
scale-color
N/A- No other change is applicable to Docsy.
✅ Color system - @chalin
While I used to think that Color system changes were optional, I've since changed my mind. IMHO, without #1388 we would have gotten weird behavior. For details see the issue's opening comment.
- [BSv5] replace lighten() by tint-color(), and var/func clean up #1384
-
⚠️ [BSv5] Fix SCSS functions import issue, and replace darken() #1388
This change only needs to be done by Docsy, not projects using Docsy. - [BSv5] UG's community page has color issues #1406
- (👀 Might be worth it later to look at the new tints & shades, and the improvements in color contrast.)
✅ Grid updates - @chalin
- Renamed .no-gutters N/A
- Columns no longer have
position: relative
applied ... - Dropped several
.order-*
classes that often went unused (beyond 5 it seems). N/A - Dropped the
.media
component. Regex:\b(^|[^@])media($|[^-])
- No other change from this section of the migration guide is applicable to Docsy.
✅ Content, Reboot, etc - @chalin
-
display-*
typography has changed (this is why the "Welcome to Docsy" on the homepage looks so different).$display*
variables have been replaced. - No other changes necessary AFAICT.
Table styles have changed. For details, see #1473.
- [BSv5] Table widths should be the same as all doc page content #1473
- [BSv5] Ensure tables are responsive by default #1476
⏭️ RTL - @chalin
- Drop current RTL support, since it's incompatible with BSv5: [BSv5] Drop import of rtl/main #1443
- Reintroduce RTL support using BSv5 RTLCSS #1442
✅ Forms
Docsy's only use of form
elements is for search, and it's a very minimal. Docsy doesn't use any of the form-specific classes that were deprecated.
✅ Components
- Accordion: future versions of docsy will support accordions - Adding shortcode for accordion component (Bootstrap 5) #1391 is ready for review @chalin @deining
- Post-migration, the following will be addressed: - [BSv5] Drop
bg-gradient-variant()
mixin #1369.
- Post-migration, the following will be addressed: - [BSv5] Drop
- Alerts - no changes necessary, but it'll be worth looking into the support for icons. @chalin
- Badges - @chalin
- Breadcrumbs
- [BS5] Breadcrumbs: active-breadcrumb fix #1414
- (Try new CSS custom property
--bs-breadcrumb-divider
for easy customization)
- Buttons - @chalin
- Toggle buttons - N/A
- Etc - N/A
- Card - @deining
- Carousel - N/A @chalin
- Close button - N/A @chalin
- Collapse - N/A @chalin
- Dropdowns @deining @chalin
- [BSv5] Dropdown for language selection fails #1381
- Dropdowns now support .dropdown-items wrapped in
<li>
s -
[BS5] Adjust HTML of dropdowns for version and lang #1415
- Jumbotron - N/A @chalin
- List group - N/A @chalin
- Navs and tabs - N/A @chalin
- Navbars @chalin
- Navbars now require a container within - [BSv5] Navbar: add inner container + cleanup #1422
- The
.active
class can no longer be applied to.nav-item
- N/A
- Offcanvas - N/A @chalin
- Pagination - N/A since Docsy doesn't currently use BS pagination, but maybe it should (Consider using Bootstrap pagination support #1423) @chalin
- Popovers @chalin
- Renamed
.arrow
to.popover-arrow
- [BSv5] Offline-search adjust arrow class name #1427 - Offline search no longer works under Bootstrap v5 #1425 - thank you to @tekezo for the fix!
- JS code updates (to enable & configure) will be handled later: Drop jQuery #1436
- Renamed
- Spinners - N/A @chalin
- Toasts - N/A @chalin
- Tooltips
- [BSv5][JS]: fix dropdowns and more #1382
- [BSv5] Drop invalid and unnecessary tooltip attribute #1407
- JS code updates (to enable & configure) will be handled later: Drop jQuery #1436
✅ Utilities - @chalin
- Renamed .float-left and .float-right to .float-start and .float-end - [BSv5] More utility updates #1361
- Renamed .ml-* and .mr-* to .ms-* and .me-*:
- Renamed .pl-* and .pr-* to .ps-* and .pe-* - [BSv5] More utility updates #1361
- Renamed .text-left and .text-right to .text-start and .text-end:
- No other change is applicable to Docsy.
Regex:
- Margin and padding:
\b([mp])[lr](-([0-5]|auto))\b
- Left/right classes:
\b((float|border|rounded|text)-)(left|right)\b
✅ Helpers - @chalin
- No changes necessary AFAICT.
✅ JavaScript
- BS dropped jQuery, but since this isn't essential for completing the migration to BSv5, we'll handle it after: Drop jQuery #1436
- Initialization / configuration and use of components will be impacted.
- Data attributes for all JavaScript plugins are now namespaced. This was addresses along with other changes, e.g.:
Other
- Delete bootstrap5 branch? #1383
- [BSv5] Refactor Click-to-copy #1447
- home page is showing horizontal scroller at bottom of site #1489