Skip to content

Version of Popper isn't compatible with Bootstrap 4, so revert? #1264

@chalin

Description

@chalin

In #1245, @geriom wrote:

This implementation requires the latest version of Popper. I ran a grep on the whole website and couldn't find any other Popper instances. So it seems updating the Popper library won't affect anything.

Docsy is still using Bootstrap 4.x, which officially requires Popper ^1.16.1, e.g., see:

https://github.com/twbs/bootstrap/blob/v4.6.2/package.json#L96-L99

  "peerDependencies": {
    "jquery": "1.9.1 - 3",
    "popper.js": "^1.16.1"
  },

I don't know if anything will break, but if the official BS docs require Popper v1, I'd stick with v1 for now --at least for the next release (0.5.0) of Docsy.

Once we upgrade to Bootstrap 5 (#470), we'll be able to upgrade Popper to v2 as well. Thoughts?

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdependenciesPull requests that update a dependency filee0-minutesEffort < 60 minp1-high

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions