Fix optional test to short-circuit #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l46kok
approved these changes
Nov 21, 2024
This was referenced Nov 22, 2024
This was referenced Nov 22, 2024
1 task
This was referenced Nov 22, 2024
Closed
This was referenced Nov 22, 2024
Merged
1 task
This was referenced Nov 23, 2024
This was referenced Nov 25, 2024
Merged
This was referenced May 19, 2025
1 task
This was referenced May 29, 2025
This was referenced Jun 1, 2025
1 task
1 task
1 task
This was referenced Jun 29, 2025
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List, map, and struct creations will short-circuit the optional element codepaths
if it is determined during planning that these literals do not contain optional
elements. The code is functional, but
hasOptionalswas triviallyfalsedueto a bug in the planning code. This has been corrected.