Skip to content

Conversation

mikes-lunarg
Copy link
Contributor

Add feature and extension boilerplate. Capture and rebuild
VkFramebufferAttachmentsCreateInfo and VkRenderPassAttachmentBeginInfo
extension structs in vkCreateFramebuffer and vkCmdBeginRenderPass,
respectively. Track the now-dynamic framebuffer image attachments as
they are recorded (in CommandBufferObject) and submitted (in DrawInfo)
instead of in the FramebufferObject.

Tested with the imageless_framebuffer sample from
google/vulkan_test_applications

Add feature and extension boilerplate. Capture and rebuild
VkFramebufferAttachmentsCreateInfo and VkRenderPassAttachmentBeginInfo
extension structs in vkCreateFramebuffer and vkCmdBeginRenderPass,
respectively. Track the now-dynamic framebuffer image attachments as
they are recorded (in CommandBufferObject) and submitted (in DrawInfo)
instead of in the FramebufferObject.

Tested with the imageless_framebuffer sample from
google/vulkan_test_applications
Put new members of each class at the end to preserve file format
backwards compatibility
Copy link
Contributor

@yalcinmelihyasin yalcinmelihyasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikes-lunarg mikes-lunarg merged commit 0d4d1cf into google:master May 13, 2022
@mikes-lunarg mikes-lunarg deleted the VK_KHR_imageless_framebuffer branch May 13, 2022 19:39
rosasco-wk pushed a commit to rosasco-wk/agi that referenced this pull request Sep 2, 2022
Add feature and extension boilerplate. Capture and rebuild
VkFramebufferAttachmentsCreateInfo and VkRenderPassAttachmentBeginInfo
extension structs in vkCreateFramebuffer and vkCmdBeginRenderPass,
respectively. Track the now-dynamic framebuffer image attachments as
they are recorded (in CommandBufferObject) and submitted (in DrawInfo)
instead of in the FramebufferObject.

Tested with the imageless_framebuffer sample from
google/vulkan_test_applications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants