Note .dockerignore in the exclusion for credentials #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README indicates that the ghe-* files should be excluded from git via the .gitignore file. However, from CI, it is less likely that users will create a new patch back to their version control with the results of their build, but it is more likely that they'll pack it into a container. This commit clarifies that the container is an equal (or larger) risk and should be excluded. This also works (for example) with Podman. See: 1. https://docs.docker.com/engine/reference/builder/ Signed-off-by: Andrew Howden <hello@andrewhowden.com>
Signed-off-by: Seth Vargo <seth@sethvargo.com>
sethvargo
approved these changes
Jan 4, 2024
sethvargo
added a commit
that referenced
this pull request
Jan 4, 2024
Closes #375 (Opening as me to trigger CI) --------- Signed-off-by: Andrew Howden <hello@andrewhowden.com> Signed-off-by: Seth Vargo <seth@sethvargo.com> Co-authored-by: Andrew Howden <hello@andrewhowden.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README indicates that the ghe-* files should be excluded from git via the .gitignore file. However, from CI, it is less likely that users will create a new patch back to their version control with the results of their build, but it is more likely that they'll pack it into a container.
This commit clarifies that the container is an equal (or larger) risk and should be excluded. This also works (for example) with Podman.
See: