Skip to content

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 15, 2025

move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner May 15, 2025 11:55
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.40%. Comparing base (c8c11b4) to head (7b76a38).
Report is 479 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21999      +/-   ##
==========================================
+ Coverage   45.36%   46.40%   +1.03%     
==========================================
  Files         244      253       +9     
  Lines       13333    14238     +905     
  Branches     2719     2925     +206     
==========================================
+ Hits         6049     6607     +558     
- Misses       6983     7278     +295     
- Partials      301      353      +52     
Flag Coverage Δ
unittests 46.40% <ø> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 changed the title udpate storage to s3 [WIP]udpate storage to s3 May 15, 2025
@wy65701436 wy65701436 force-pushed the aws branch 2 times, most recently from 7c90629 to 08bc77e Compare May 15, 2025 12:37
@Vad1mo
Copy link
Member

Vad1mo commented May 15, 2025

What data is going to end up on AWS s3?

Why not store these artifacts next to the code on GitHub?

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow#uploading-build-and-test-artifacts

@wy65701436 wy65701436 force-pushed the aws branch 5 times, most recently from 26ebabe to a649e67 Compare May 16, 2025 07:05
@wy65701436 wy65701436 added the release-note/infra Infra related changes e.g. release, test, ship etc... label May 16, 2025
@wy65701436 wy65701436 changed the title [WIP]udpate storage to s3 udpate storage to s3 May 16, 2025
move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 enabled auto-merge (squash) May 16, 2025 09:53
@wy65701436 wy65701436 merged commit 2faff8e into goharbor:main May 16, 2025
12 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request May 16, 2025
move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Signed-off-by: wang yan <wangyan@vmware.com>
MinerYang pushed a commit that referenced this pull request May 19, 2025
udpate storage to s3 (#21999)

move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Signed-off-by: wang yan <wangyan@vmware.com>
TMHBOFH pushed a commit to TMHBOFH/harbor that referenced this pull request May 21, 2025
move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: TMHBOFH <itsystem.bofh@gmail.com>
wy65701436 added a commit to wy65701436/harbor that referenced this pull request May 22, 2025
move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436 added a commit that referenced this pull request May 22, 2025
move the build storage from google storage to the CNCF S3 storage

Currently, we use the internal GCR to store all dev builds for nightly testing, development, and as candidates for RC and GA releases. However, this internal Google storage will no longer be available, this pull request it to move to the CNCF-hosted S3 storage.

Signed-off-by: wang yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants