Fix: Helm Chart Copy Button in UI #21969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bupd <bupdprasanth@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21969 +/- ##
==========================================
+ Coverage 45.36% 46.43% +1.06%
==========================================
Files 244 253 +9
Lines 13333 14238 +905
Branches 2719 2925 +206
==========================================
+ Hits 6049 6611 +562
- Misses 6983 7274 +291
- Partials 301 353 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
xuelichao
reviewed
May 8, 2025
...ct/artifact-list-page/artifact-list/artifact-list-tab/pull-command/pull-command.component.ts
Show resolved
Hide resolved
Signed-off-by: bupd <bupdprasanth@gmail.com>
xuelichao
approved these changes
May 9, 2025
| Clients.CHART | ||
| ); | ||
| } else { | ||
| return ''; |
There was a problem hiding this comment.
OverAll LGTM and Nice to have some unit tests to cover those changes as suggested by Codecov
Please let me know your idea about it
bupd
added a commit
to bupd/harbor
that referenced
this pull request
May 9, 2025
* fix: helm chart copy btn in UI Signed-off-by: bupd <bupdprasanth@gmail.com> * add: tests for pull command component in UI Signed-off-by: bupd <bupdprasanth@gmail.com> --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
bupd
added a commit
to bupd/harbor
that referenced
this pull request
May 9, 2025
* fix: helm chart copy btn in UI Signed-off-by: bupd <bupdprasanth@gmail.com> * add: tests for pull command component in UI Signed-off-by: bupd <bupdprasanth@gmail.com> --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
wy65701436
pushed a commit
that referenced
this pull request
May 9, 2025
Fix: Helm Chart Copy Button in UI (#21969) * fix: helm chart copy btn in UI * add: tests for pull command component in UI --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
May 16, 2025
* fix: helm chart copy btn in UI Signed-off-by: bupd <bupdprasanth@gmail.com> * add: tests for pull command component in UI Signed-off-by: bupd <bupdprasanth@gmail.com> --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Please indicate you've done the following: