Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented Apr 16, 2025

This pull request includes updates to the golangci-lint version and significant changes to the golangci-lint configuration file. These changes aim to improve the linting process and ensure the codebase adheres to the latest standards.

Updates to golangci-lint version:

  • Makefile: Updated the golangci-lint installation command to use version v2.1.2 instead of v1.55.2.
  • tests/ci/ut_install.sh: Updated the golangci-lint installation command to use version v2.1.2 instead of v1.61.0.

Changes to golangci-lint configuration:

  • src/.golangci.yaml:
    • Removed specific linter settings and simplified the configuration.
    • Enabled and disabled specific linters to optimize the linting process.
    • Added settings for goheader, misspell, and staticcheck.
    • Included exclusion rules for generated files and specific paths.Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added the dependencies Pull requests that update a dependency file label Apr 16, 2025
@chlins chlins requested a review from a team as a code owner April 16, 2025 09:07
@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.46%. Comparing base (c8c11b4) to head (2f0fcb6).
Report is 457 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21887      +/-   ##
==========================================
+ Coverage   45.36%   46.46%   +1.10%     
==========================================
  Files         244      253       +9     
  Lines       13333    14233     +900     
  Branches     2719     2924     +205     
==========================================
+ Hits         6049     6614     +565     
- Misses       6983     7270     +287     
- Partials      301      349      +48     
Flag Coverage Δ
unittests 46.46% <ø> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlins chlins force-pushed the chore/bump-golangci-lint-v2 branch from 1a4838c to aa55783 Compare April 16, 2025 09:22
Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the chore/bump-golangci-lint-v2 branch 3 times, most recently from 1d41bb9 to b6465b6 Compare April 16, 2025 12:39
Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the chore/bump-golangci-lint-v2 branch from b6465b6 to 2f0fcb6 Compare April 16, 2025 12:56
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 9dcbd56 into goharbor:main Apr 17, 2025
12 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 16, 2025
Signed-off-by: chlins <chlins.zhang@gmail.com>
wy65701436 added a commit that referenced this pull request Jul 30, 2025
* bump golang version

Up golang from v2.13.11 to v2.14.5

1, cherry-pick #21887 bump golangci-lint to v2
2, bump mockery 

These changes are required due to the upgrade to Go v1.24.5

Signed-off-by: wy65701436 <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants