Skip to content

fix(cmd/gf): gen service error when there's version number at the end of package import path #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2024
Merged

fix(cmd/gf): gen service error when there's version number at the end of package import path #3836

merged 1 commit into from
Oct 5, 2024

Conversation

oldme-git
Copy link
Member

Dear review:
当 logic 中存在类似携带版本号的引入包名，例如：github.com/gogf/gf/v2，那么在生成 service 的时候，会导致该包名识别为 v2。
故此当结尾以版本号结尾时，向前推进一位，使用正确的 gf 做为包名。

Fixed #3835

@gqcn gqcn changed the title fix(cmd/gf): gen service error when the package version number at the end fix(cmd/gf): gen service error when there's version number at the end of package import path Oct 5, 2024
@gqcn gqcn merged commit 183395f into master Oct 5, 2024
40 checks passed
@gqcn gqcn deleted the fix/3835 branch October 5, 2024 04:25
@BrewTestBot BrewTestBot mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/gf: It makes error that the package version number at the end
2 participants
@oldme-git @gqcn