Skip to content

feat(contrib/log/zap): If disable this level of logging entirely, av… #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat(contrib/log/zap): If disable this level of logging entirely, av… #3357

merged 1 commit into from
Sep 2, 2024

Conversation

harbourlga
Copy link
Contributor

@harbourlga harbourlga commented Jul 3, 2024 •
edited
Loading

Description (what this PR does / why we need it):

  • The zap log plug-in implemented for contrib/log currently filters unnecessary log levels after the log information is formatted, which will cause a lot of additional overhead.
  • Referring to the implementation of SugaredLogger, it will first determine whether the log level meets the current needs before formatting the string.

Which issue(s) this PR fixes (resolves / be part of):

None

Other special notes for the reviewers:

None

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 3, 2024
@harbourlga harbourlga force-pushed the feat/zap-log-levelfiltering branch from 6fb5b8e to 97d04f0 Compare July 3, 2024 06:57
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 3, 2024
@harbourlga harbourlga changed the title chore(contrib/log/zap): If disable this level of logging entirely, av… feat(contrib/log/zap): If disable this level of logging entirely, av… Jul 3, 2024
@harbourlga harbourlga force-pushed the feat/zap-log-levelfiltering branch from 97d04f0 to 982b998 Compare July 3, 2024 07:00
shenqidebaozi
shenqidebaozi previously approved these changes Aug 28, 2024
View reviewed changes
@dosubot dosubot bot added the LGTM label Aug 28, 2024
demoManito
demoManito reviewed Aug 30, 2024
View reviewed changes
@harbourlga
feat(contrib/log/zap): If disable this level of logging entirely, avo…
17876b5 
…id additional overhead

  * goimports

* gofmt

* third-party packages should be placed before github.com/go-kratos
@harbourlga harbourlga force-pushed the feat/zap-log-levelfiltering branch from f927e8e to 17876b5 Compare September 2, 2024 01:40
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 2, 2024
@shenqidebaozi shenqidebaozi merged commit 6963a8a into go-kratos:main Sep 2, 2024
33 checks passed
@shenqidebaozi shenqidebaozi mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demoManito demoManito demoManito approved these changes

@shenqidebaozi shenqidebaozi shenqidebaozi approved these changes

Assignees
No one assigned
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harbourlga @demoManito @shenqidebaozi