feat(log): Prevent log.Helper sprintf from running early #3209 #3221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
- Coverage 84.72% 84.45% -0.28%
==========================================
Files 88 88
Lines 3993 4013 +20
==========================================
+ Hits 3383 3389 +6
- Misses 438 446 +8
- Partials 172 178 +6 ☔ View full report in Codecov by Sentry. |
Windfarer
reviewed
Mar 5, 2024
shenqidebaozi
approved these changes
Mar 11, 2024
daemon365
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
log 在在开发中会使用很多 Debug / Debugf 日志，在生产服务中可能会配置为 Info 级以上
但 log.Helper 函数中会在进入
提前运行了
fmt.Sprint、fmt.Sprintf在较高并发的情况下，带来了非常高的字符串拼接耗损。Which issue(s) this PR fixes (resolves / be part of):
fixes/resolves #3209
Other special notes for the reviewers: