fix: logging middleware caller issue #3133 #3134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3134 +/- ##
==========================================
+ Coverage 84.43% 84.69% +0.26%
==========================================
Files 88 88
Lines 3983 3986 +3
==========================================
+ Hits 3363 3376 +13
+ Misses 443 438 -5
+ Partials 177 172 -5 ☔ View full report in Codecov by Sentry. |
shenqidebaozi
approved these changes
Jan 7, 2024
|
@hawkingrei Could you help me to review this code? Changes are well-tested and there was no lint issue. |
daemon365
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Fix caller path issue in logging middleware.
Which issue(s) this PR fixes (resolves / be part of):
fixes/resolves #3133
Other special notes for the reviewers:
Testing code maybe a little bit hard for understanding.