fix: Logging middleware will be missing trace_id when logger is filterlogger #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
- Coverage 85.18% 85.15% -0.03%
==========================================
Files 88 88
Lines 3840 3846 +6
==========================================
+ Hits 3271 3275 +4
- Misses 396 397 +1
- Partials 173 174 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@Cynicism-zx please fix lint failed |
|
@shenqidebaozi fixed |
stonelgh
reviewed
Mar 9, 2023
Comment on lines
+58
to
+64
| f, ok := l.(*Filter) | ||
| if ok { | ||
| lg, ok := f.logger.(*logger) | ||
| if ok { | ||
| return &logger{logger: lg.logger, prefix: lg.prefix, hasValuer: lg.hasValuer, ctx: ctx} | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggest to replace the if !ok {...} block with something like the following to be able to handle nested Filters:
for {
if f, ok := l.(*Filter); ok {
l = f.logger
} else {
break
}
}
c, ok = l.(*logger)
if !ok {
return &logger{logger: l, ctx: ctx}
}
|
@Cynicism-zx @shenqidebaozi Could you please comment? |
|
don't simple to using origin logger, It will cause the Filter not working. |
freezeChen
added a commit
to freezeChen/kratos
that referenced
this pull request
Jun 15, 2023
fix logging middle don't get trace_id value when logger is filterLogger Which issue(s) this PR fixes (resolves / be part of): go-kratos#2570 go-kratos#2571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
修复启用链路追逐后log中间件使用logfilter后,打印的请求日志中缺失trace.id值,如下
Which issue(s) this PR fixes (resolves / be part of):
fix/logfilter #2570
Other special notes for the reviewers:
应该在log.WithContext()方法中进一步断言logger类型,并取出初始logger的prefix