Skip to content

fix graceful shutdown #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Mar 10, 2022

Description (what this PR does / why we need it):

Fix wrong graceful shutdown

Which issue(s) this PR fixes (resolves / be part of):

fixes #1856

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #1873 (c3d9759) into main (ac99a5c) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
- Coverage   80.89%   80.79%   -0.11%     
==========================================
  Files          80       80              
  Lines        3565     3566       +1     
==========================================
- Hits         2884     2881       -3     
- Misses        477      479       +2     
- Partials      204      206       +2     
Impacted Files Coverage Δ
app.go 83.65% <100.00%> (+0.15%) ⬆️
config/file/watcher.go 59.37% <0.00%> (-6.25%) ⬇️
config/file/file.go 61.90% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac99a5c...c3d9759. Read the comment docs.

@shenqidebaozi shenqidebaozi merged commit f68702a into go-kratos:main Mar 15, 2022
tonybase pushed a commit that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graceful shutdown err
4 participants