Skip to content

backport:[1.9] - Run CORS handler first for /api routes (#7967) #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

backport:[1.9] - Run CORS handler first for /api routes (#7967) #8053

merged 1 commit into from
Sep 2, 2019

Conversation

tamalsaha
Copy link
Contributor

Signed-off-by: Tamal Saha tamal@appscode.com

@tamalsaha
Run CORS handler first for /api routes (go-gitea#7967)
f7d9619 
Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha changed the title [backport]1.9 - Run CORS handler first for /api routes (#7967) backport:[1.9] - Run CORS handler first for /api routes (#7967) Sep 2, 2019
@tamalsaha
Copy link
Contributor Author

@lafriks , sorry I did not see your comment sooner. I have opened this pr to backport this change.

xref: #7967 (comment)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 2, 2019
@lafriks lafriks added this to the 1.9.3 milestone Sep 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 2, 2019
@lafriks lafriks merged commit 9bea8d8 into go-gitea:release/v1.9 Sep 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jun 3, 2025
@viceice
chore: drop unused misspell (go-gitea#8058)
549fcff 
Package not used

- closes go-gitea#8053

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8058
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-committed-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tamalsaha @lafriks @guillep2k @GiteaBot