Skip to content

Conversation

DLambros91
Copy link
Contributor

Added Security Tag to description and to code. Removed old PR due to issues.

Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DLambros91
Copy link
Contributor Author

Please let me know if I should make any further additions regarding this at this time.

@cristaloleg cristaloleg changed the title Added Security Tag framework/lintmain: add security tag Sep 28, 2020
@cristaloleg cristaloleg merged commit d2bb441 into go-critic:master Sep 28, 2020
@cristaloleg
Copy link
Member

@DLambros91 no, nothing at the moment, thank you for the contribution :)

@cristaloleg cristaloleg mentioned this pull request Oct 11, 2020
dfarrell07 added a commit to dfarrell07/go-critic that referenced this pull request Feb 1, 2022
Document that the security tag is disabled by default. Also document
that there are currently no checks in the security tag, so enabling it
will fail.

./gocritic check -v -enable='#security
init checkers: empty checkers set selected

When trying to enable the tag through golangci-lint, this is the error:

ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't
exist

The tag was added in go-critic#989.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07 added a commit to dfarrell07/go-critic that referenced this pull request Feb 1, 2022
Document that the security tag is disabled by default. Also document
that there are currently no checks in the security tag, so enabling it
will fail.

$ ./gocritic check -v -enable='#security
init checkers: empty checkers set selected
$ echo $?
1

When trying to enable the tag through golangci-lint, this is the error:

ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't
exist

The tag was added in go-critic#989.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07 added a commit to dfarrell07/go-critic that referenced this pull request Feb 1, 2022
Document that the security tag is disabled by default. Also document
that there are currently no checks in the security tag, so enabling it
will fail.

$ ./gocritic check -v -enable='#security
init checkers: empty checkers set selected
$ echo $?
1

When trying to enable the tag through golangci-lint, this is the error:

ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't
exist

The tag was added in go-critic#989.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
quasilyte pushed a commit that referenced this pull request Feb 1, 2022
Document that the security tag is disabled by default. Also document
that there are currently no checks in the security tag, so enabling it
will fail.

When trying to enable the tag through golangci-lint, this is the error:

ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't
exist

The tag was added in #989.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants