-
Notifications
You must be signed in to change notification settings - Fork 130
framework/lintmain: add security tag #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Security Tag to README
cristaloleg
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
quasilyte
approved these changes
Sep 28, 2020
Please let me know if I should make any further additions regarding this at this time. |
@DLambros91 no, nothing at the moment, thank you for the contribution :) |
Closed
dfarrell07
added a commit
to dfarrell07/go-critic
that referenced
this pull request
Feb 1, 2022
Document that the security tag is disabled by default. Also document that there are currently no checks in the security tag, so enabling it will fail. ./gocritic check -v -enable='#security init checkers: empty checkers set selected When trying to enable the tag through golangci-lint, this is the error: ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't exist The tag was added in go-critic#989. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
added a commit
to dfarrell07/go-critic
that referenced
this pull request
Feb 1, 2022
Document that the security tag is disabled by default. Also document that there are currently no checks in the security tag, so enabling it will fail. $ ./gocritic check -v -enable='#security init checkers: empty checkers set selected $ echo $? 1 When trying to enable the tag through golangci-lint, this is the error: ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't exist The tag was added in go-critic#989. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
added a commit
to dfarrell07/go-critic
that referenced
this pull request
Feb 1, 2022
Document that the security tag is disabled by default. Also document that there are currently no checks in the security tag, so enabling it will fail. $ ./gocritic check -v -enable='#security init checkers: empty checkers set selected $ echo $? 1 When trying to enable the tag through golangci-lint, this is the error: ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't exist The tag was added in go-critic#989. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
quasilyte
pushed a commit
that referenced
this pull request
Feb 1, 2022
Document that the security tag is disabled by default. Also document that there are currently no checks in the security tag, so enabling it will fail. When trying to enable the tag through golangci-lint, this is the error: ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't exist The tag was added in #989. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Security Tag to description and to code. Removed old PR due to issues.