README.md: Doc sec tag disabled, fails if enabled #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that the security tag is disabled by default. Also document that there are currently no checks in the security tag, so enabling it will fail. $ ./gocritic check -v -enable='#security init checkers: empty checkers set selected $ echo $? 1 When trying to enable the tag through golangci-lint, this is the error: ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't exist The tag was added in go-critic#989. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
65cbfc0 to
203df08
Compare
quasilyte
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that the security tag is disabled by default. Also document
that there are currently no checks in the security tag, so enabling it
will fail.
$ ./gocritic check -v -enable='#security
init checkers: empty checkers set selected
$ echo $?
1
When trying to enable the tag through golangci-lint, this is the error:
ERRO Invalid gocritic settings: gocritic [enabled]tag "security" doesn't
exist
The tag was added in #989.
Signed-off-by: Daniel Farrell dfarrell@redhat.com