Add junit report format #920
Conversation
|
Hey @zricethezav, this PR is ready for review 🚀 |
|
@maltemorgenstern would you mind updating this? Also since I do not have any junit experience would you mind keeping an eye on this moving forward when it gets merged in? |
|
Hey @zricethezav
Sure - I will take a look at this the next few days and solve the conflicts!
I must admit that I am not really familiar with the But I should definitely be able to take a look at future PRs and test them with the GitLab integration. |
|
@zricethezav this PR is now up-to-date again and ready for review/merge. |
|
Would really love to see junit support to integrate with CI and have a standardized format. ;) |
|
Hey @zricethezav, |
|
been keeping an eye on the PR, as it seems really useful. it has been open for quite some time... any plans on merging it? |
|
|
||
| for _, test := range tests { | ||
| // create tmp file using os.TempDir() | ||
| tmpfile, err := os.Create(filepath.Join(tmpPath, test.testReportName+".xml")) |
There was a problem hiding this comment.
@zricethezav report_test.go declares tmpPath but this file doesn't (re: comment on Discord).
There was a problem hiding this comment.
can confirm tmpPath is not declared. my pipelines broke today.
* add junit report format * add fingerprint to expected test result to fix tests * fix expected junit test report
Description:
This merge request adds
junitas a new report format.As described in #404 junit reports can be integrated with CI/CD systems as test reports for easier visualisation in the browser and merge requests. I tested these changes with the GitLab Unit Test Reports feature.
That's why the generated
junitformat follows the GitLab requirements. In general it is based on the IBM junit format with some additional and missing attributes (some of them could be added in the future if needed).Here is an example of the GitLab integration:
Click to expand!
Links/Docs:
This MR closes #404
Unrelated change
I also added
testdata/expected/report/*.got.*to the.gitignorebecause they should not be commited to the repo.Checklist: