fix(FileViewer): Avoid crash on animated image file #12274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any example of a file that triggers this problem? |
RussKie
reviewed
Mar 23, 2025
src/app/GitUI/Editor/FileViewer.cs
Outdated
| if (image.GetFrameCount(frameDimension) > 1) | ||
| { | ||
| image.SelectActiveFrame(frameDimension, 0); | ||
| image = new Bitmap(image); |
There was a problem hiding this comment.
I suspect we might be leaking a handle here...
RussKie
reviewed
Mar 23, 2025
This would require integration testing. Integration test cases are too expensive and too difficult to setup stably. It is not worth IMO, specifically for this workaround for a bug in the platform, which the debugger even cannot catch. |
in order to avoid exception in PictureBox.WndProc Refs: gitextensions#12274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12269
Proposed changes
FileViewer: Render only the first frame of an animated image in order to avoid exception in
PictureBox.WndProcScreenshots
Before
first frame, then red frame and cross
After
first frame
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.