feat(CheckListSettingsPage): Improve display of git version #12264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
good change but do not work for me |
|
|
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the display and detection of the Git version in the ChecklistSettingsPage by distinguishing between the native and used (WSL) Git versions. It also simplifies Git version retrieval by identifying it solely using the GitExecutable.Command.
- Changed ChecklistSettingsPage to compute and display a combined Git version string.
- Updated GitVersion to use a simplified API with nullable annotations.
- Adjusted GitModule to remove unused parameters related to WSL.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/GitUI/CommandsDialogs/SettingsDialog/Pages/ChecklistSettingsPage.cs | Updates UI logic to display native and used Git versions appropriately. |
| src/app/GitCommands/Git/GitVersion.cs | Refactors the Git version retrieval method with nullable enable and cleaner caching logic. |
| src/app/GitCommands/Git/GitModule.cs | Removes the redundant _wslDistro parameter to align with the simplified GitVersion API. |
|
Works as intended - for me |
mstv
added a commit
to mstv/gitextensions
that referenced
this pull request
Mar 14, 2025
and apply code style Refs: gitextensions#12264
|
Finally, I have realized that the |
Closed
gerhardol
approved these changes
Mar 15, 2025
Comment on lines
49
to
51
| = gitExecutable is null ? AppSettings.GitCommand | ||
| : string.IsNullOrWhiteSpace(gitExecutable.PrefixArguments) ? gitExecutable.Command | ||
| : $"{gitExecutable.Command} {gitExecutable.PrefixArguments}"; |
There was a problem hiding this comment.
please reformat or indent
Suggested change
| = gitExecutable is null ? AppSettings.GitCommand | |
| : string.IsNullOrWhiteSpace(gitExecutable.PrefixArguments) ? gitExecutable.Command | |
| : $"{gitExecutable.Command} {gitExecutable.PrefixArguments}"; | |
| = gitExecutable is null | |
| ? AppSettings.GitCommand | |
| : string.IsNullOrWhiteSpace(gitExecutable.PrefixArguments) | |
| ? gitExecutable.Command | |
| : $"{gitExecutable.Command} {gitExecutable.PrefixArguments}"; |
gerhardol
approved these changes
Mar 16, 2025
by always identifying by means of gitExecutable.Command+.PrefixArguments Refs: gitextensions#12264
and apply code style Refs: gitextensions#12264
and display versions of used git (WSL) and configured native git Refs: gitextensions#12264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12185 (comment)
Proposed changes
ChecklistSettingsPage:
GitVersion:
GitVersionby means ofgitExecutable.Command + gitExecutable.PrefixArgumentsIExecutable:
PrefixArgumentsScreenshots
Before
After
Test methodology
Please do not squash merge
✒️ I contribute this code under The Developer Certificate of Origin.