Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Feb 15, 2025

Fixes "unhandled exception" popup (repeatedly seen on OperationCanceledException in test execution)

Proposed changes

  • Wrap handler code with TaskManager.HandleExceptions(..., Application.OnThreadException)

Screenshots

N/A

Test methodology

  • run the tests

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Feb 15, 2025
@RussKie RussKie requested a review from Copilot February 16, 2025 00:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/app/GitUI/UserControls/FileStatusList.cs: Evaluated as low risk

@mstv mstv force-pushed the fix/handle_exceptions branch from 09d5ce0 to bb077e7 Compare February 16, 2025 12:21
@mstv mstv merged commit bb077e7 into gitextensions:master Feb 16, 2025
2 of 4 checks passed
@mstv mstv deleted the fix/handle_exceptions branch February 16, 2025 12:24
@mstv mstv added this to the v5.3 milestone Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants