feat: bold-bold ansi terminal colors #12189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstv
approved these changes
Feb 11, 2025
There is no difference also with difft with the default theme, I have not seen any Git usage of bold-bold so there should be none. |
It was my justification for skipping a detailed review and testing myself. The added testcases pass. |
Some terminals allow bold-bold colors. For instance Difftastic emitts this in dark mode. Handle dark mode for ansi default text color. Add a way to generate AnsiTerminalColors.diff, to display the terminal colors. (Requires commenting out code.) Refs: gitextensions#12189
5db7215 to
e106d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix: MakeBackgroundDarkerBy for colors instead of known names
To simplify a few changes
feat: bold-bold ansi terminal colors
Some terminals allow bold-bold colors.
For instance Difftastic emits this in dark mode.
Handle dark mode for ansi default text color.
Add a way to generate AnsiTerminalColors.diff,
to display the terminal colors.
(Requires commenting out code.)
Note: I ended up proposing another solution for dark mode other than bold-bold.
Screenshots
There are no diff for normal output, but the bold-bold is displayed and the "test file" is updated.
The bold-bold were not visible before
Before
After
Test methodology
Added tests, also for existing
Merge strategy
✒️ I contribute this code under The Developer Certificate of Origin.