fix: Improve blame loading and other minor #12158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
reviewed
Jan 22, 2025
| @@ -1517,7 +1517,7 @@ private void FileStatusListView_ContextMenu_Opening(object? sender, CancelEventA | |||
| } | |||
|
|
|||
| // Show 'Show file differences for all parents' menu item if it is possible that there are multiple first revisions | |||
| bool mayBeMultipleRevs = _enableDisablingShowDiffForAllParents && GitItemStatusesWithDescription.Count > 1; | |||
| bool mayBeMultipleRevs = _enableDisablingShowDiffForAllParents; | |||
There was a problem hiding this comment.
I believe this was intentional, there were users that were very annoyed by multi select
but it is fine for me
RussKie
approved these changes
Jan 23, 2025
b9c773c to
97c3986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed changes
BlameControl: Do not cancel loading if nothing changed; combine cancellation tokens; use safe init values for_lastTooltipX/YAsyncLoader: Make clearer & enablenullableRevisionDiffControl: ConvertIEnumerableto array in order to avoid possible multiple evaluationFileStatusList: Avoid one-way menu item "Show differences for all parents in browse dialog"Screenshots
Before
menu item disappeared when unchecked
After
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.