feat: Avoid just "app" / "repo" / "repository" in app title #12138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Jan 14, 2025
| { | ||
| private const string RepositoryDescriptionFileName = "description"; | ||
| private const string DefaultDescription = "Unnamed repository; edit this file 'description' to name the repository."; | ||
|
|
||
| [GeneratedRegex("^(repo(sitory)?)$", RegexOptions.IgnoreCase | RegexOptions.ExplicitCapture)] |
There was a problem hiding this comment.
It also feels that we're adding an alternative to the "description" functionality (which is quite niche, IMO).
My only concern here is there we're harcoding a naming pattern which isn't universal... Back when I worked at a bank, we had a naming convention resembling "solution/project_name/app". If we're going down this route, I feel that the pattern should be customisable.
RussKie
approved these changes
Jan 16, 2025
gerhardol
pushed a commit
to gerhardol/gitextensions
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some repos include submodules with additional subfolders
Currently, these submodules cannot be distinguished in GE's title bar.
Add a regex for skipping uninformative repo names "repo" and "repository".
Screenshots
Before
After
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.