fix(blame previous): Remove restriction to availibility of the actual revision #12090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gerhardol
reviewed
Dec 7, 2024
| // Origin line of commit selected is final line of the previous blame commit | ||
| int finalLineNumberOfPreviousBlame = _lastBlameLine!.OriginLineNumber; | ||
| int originalLineNumberOfPreviousBlame = _gitBlameParser.GetOriginalLineInPreviousCommit(selectedRevision, blameInfo.filename, finalLineNumberOfPreviousBlame); | ||
| int originalLineNumberOfPreviousBlame = _gitBlameParser.GetOriginalLineInPreviousCommit(blameInfo.selectedRevision, blameInfo.filename, finalLineNumberOfPreviousBlame); |
There was a problem hiding this comment.
0
This is the previous revision in grid.
I suggest this is separate or that the txt is changed.
Will not vote against though.
to availibility of the actual revision - use visible previous revision as fallback - add mnemonics Refs: gitextensions#12090
f077806 to
f5cfff2
Compare
gerhardol
approved these changes
Dec 9, 2024
| @@ -47,6 +47,8 @@ public sealed partial class BlameControl : GitModuleControl | |||
| private bool _changingScrollPosition; | |||
| private IRepositoryHostPlugin? _gitHoster; | |||
| private static readonly IList<Color> AgeBucketGradientColors = GetAgeBucketGradientColors(); | |||
| private static readonly TranslationString _blameActualPreviousRevision = new("&Blame actual previous revision"); | |||
There was a problem hiding this comment.
Suggested change
| private static readonly TranslationString _blameActualPreviousRevision = new("&Blame actual previous revision"); | |
| private static readonly TranslationString _blameActualPreviousRevision = new("&Blame previous revision"); |
| @@ -47,6 +47,8 @@ public sealed partial class BlameControl : GitModuleControl | |||
| private bool _changingScrollPosition; | |||
| private IRepositoryHostPlugin? _gitHoster; | |||
| private static readonly IList<Color> AgeBucketGradientColors = GetAgeBucketGradientColors(); | |||
| private static readonly TranslationString _blameActualPreviousRevision = new("&Blame actual previous revision"); | |||
| private static readonly TranslationString _blameVisiblePreviousRevision = new("&Blame visible previous revision"); | |||
There was a problem hiding this comment.
Suggested change
| private static readonly TranslationString _blameVisiblePreviousRevision = new("&Blame visible previous revision"); | |
| private static readonly TranslationString _blameVisiblePreviousRevision = new("&Blame previous visible revision"); |
Review comment: Pronounce "previous"
Review comment (after actually reading all)
gerhardol
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10946
Proposed changes
BlameControlScreenshots
Before
context menu item disabled
After
context menu item enabled if there is shown a (virtual) parent
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.