Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Nov 22, 2024

Proposed changes

  • fix(FileStatusList): Extract function GetFileStatusListTop and consider all additional boxes
    in order to fixup the position of "Loading data..." - particularly on empty (artificial) commits, the just shown empty ComBox could be covered by the ListView
  • fix(FileStatusList): Expand group of selected item
    otherwise the selection of a diff file is not visible because all diff groups are collapsed for git-grep
  • fix(GetGrepFileAsync): Quote filename
    in order to support files with spaces in their name
  • fix(git-grep): Go to first match if showing the entire file

Screenshots

Not really applicable

Test methodology

  • manual

Please do not squash merge


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Nov 22, 2024
@mstv mstv merged commit 7563585 into gitextensions:master Nov 24, 2024
3 of 4 checks passed
@mstv mstv deleted the fix/gitgrep branch November 24, 2024 18:44
@mstv mstv added this to the v5.2 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants