Skip to content

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented May 8, 2024

Proposed changes

  • Display tag as patch (to benefit diff syntax highlighting)
  • improve recovery file format detection and saving
    • improve heuristic to determine file type
    • better default name for recovered files (by using the file type found)
    • allow user to more easily save as another (similar) file type

Screenshots

Before

  • tag:

image

  • File recovery:

image

image

After

  • tag:

image

  • better detection of file type and better saving UX:

image

image

Test methodology

  • Manual

Test environment(s)

  • GIT
  • Windows

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have not run

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not run.
The heuristics is improved, seem good enough

* improve heuristic to determine file type
* better default name for recovered files (by using the file type found)
* allow user to more easily save as another (similar) file type

+ display tag as patch (to benefit syntax highlighting)

PR gitextensions#11727
@pmiossec pmiossec force-pushed the improve_recovery_ux branch from dd7c5f4 to dd2894e Compare May 10, 2024 10:03
@pmiossec pmiossec merged commit 29f8feb into gitextensions:master May 10, 2024
@pmiossec pmiossec deleted the improve_recovery_ux branch May 10, 2024 10:22
@RussKie RussKie added this to the vNext milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants