Do not migrate empty settings #11384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Nov 23, 2023
RussKie
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Could you please add a regression test to https://github.com/gitextensions/gitextensions/blob/master/UnitTests/GitCommands.Tests/UserRepositoryHistory/RepositoryStorageTests.cs?
Done I have not investigated why this run repeatedly, I would expect it to only run once |
RussKie
approved these changes
Nov 25, 2023
mstv
pushed a commit
to mstv/gitextensions
that referenced
this pull request
Nov 26, 2023
* Do not migrate empty settings * fixup! Do not migrate empty settings --------- Co-authored-by: Gerhard Olsson <gerhardol@users.noreply.github.com> (cherry picked from commit 2b124ac)
This was
linked to
issues
Nov 26, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11383
Proposed changes
Do not migrate empty settings
Test methodology
manual edit the settings file
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.