Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Nov 16, 2023

Fixes https://github.com/gitextensions/gitextensions/pull/11308/files#r1394980653

Proposed changes

  • Restore adapted path for commit command
  • Rename GetGitExecPath to GetPathForGitExecution in order to avoid misleading abbreviation
  • Force all callers to pass GitModule.GetPathForGitExecution

Screenshots

N/A

Test methodology

  • adapted existing tests
  • add testcase for the regression

Please do not squash merge!


✒️ I contribute this code under The Developer Certificate of Origin.

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring
I have triedto review the scenarios that are changed, did not see anything.
Briefly run.

@RussKie
Copy link
Member

RussKie commented Nov 18, 2023

@mstv when you're ready

@mstv mstv force-pushed the fix/commit_cmdargs branch from 194a7f3 to 569ce7a Compare November 18, 2023 08:53
@mstv mstv merged commit 569ce7a into gitextensions:master Nov 18, 2023
@ghost ghost added this to the vNext milestone Nov 18, 2023
@mstv mstv deleted the fix/commit_cmdargs branch November 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants