Add Revision Graph option to fan out all children lanes directly at parent #11327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Nov 5, 2023
| { | ||
| public readonly bool MergeGraphLanesHavingCommonParent; | ||
|
|
||
| public RevisionGraphConfig() |
There was a problem hiding this comment.
Do you plan to add more properties here?
There was a problem hiding this comment.
Yes, I want to add another two independent options here and in AppSettings:
- "Render graph with diagonals"
- "Straighten graph diagonals"
and a derived one here:
ReduceGraphCrossingsin the third commit of this PR
👍 |
RussKie
approved these changes
Nov 10, 2023
mstv
added a commit
to mstv/gitextensions
that referenced
this pull request
Nov 10, 2023
mstv
added a commit
to mstv/gitextensions
that referenced
this pull request
Nov 10, 2023
f3fff3f to
e24e622
Compare
e24e622 to
d1e0e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
readonly struct RevisionGraphConfigin order to not change settings during graph renderingreadonly ref struct RevisionGrid.Graph.Rendering.Contextin order to reduce the number of arguments to passRevisionGraphRevision.ParentCountin order to avoid enumeration ofConcurrentQueueScreenshots
Test methodology
Please do not squash merge!
✒️ I contribute this code under The Developer Certificate of Origin.