IDE0008 Use explicit type instead of var #11284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several manual changes. A few IDE0090 was addressed too.
9670bdc to
a7b3362
Compare
|
I would then update editor config file to be at least a warning if not an error if you are taking this stance fully. |
mstv
approved these changes
Oct 18, 2023
| @@ -248,11 +248,11 @@ public void Error_raised_via_event_and_not_marked_as_handled_faults_task() | |||
|
|
|||
| Exception ex = new(); | |||
|
|
|||
| var loadTask = ThreadHelper.JoinableTaskFactory.RunAsync(() => _loader.LoadAsync( | |||
| Microsoft.VisualStudio.Threading.JoinableTask loadTask = ThreadHelper.JoinableTaskFactory.RunAsync(() => _loader.LoadAsync( | |||
There was a problem hiding this comment.
❔
Suggested change
| Microsoft.VisualStudio.Threading.JoinableTask loadTask = ThreadHelper.JoinableTaskFactory.RunAsync(() => _loader.LoadAsync( | |
| using Microsoft.VisualStudio.Threading; | |
| JoinableTask loadTask = ThreadHelper.JoinableTaskFactory.RunAsync(() => _loader.LoadAsync( |
There was a problem hiding this comment.
Also did this change in a general way, fixing IDE0001
Will change this to warning. Error is not seen in AppVeyor builds. |
d40663f to
8df953a
Compare
|
Would like to merge this tomorrow to avoid merge conflicts - most other prs are affected by #11276 anyway. |
|
Merge at will
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11276
Proposed changes
Several manual changes, type alias, indentations, casing
A few IDE0090 was addressed too (that appeared after applying IDE0008
A few occurrences with anonymous types remains
I have not reviewed the changes (other than my manual overrides), it compiles and started up.
Test methodology
Compile
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.