Remove use of var to follow project code style
#11276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
reviewed
Oct 16, 2023
gerhardol
approved these changes
Oct 16, 2023
| var firstId = Module.RevParse(gitStash.Name + "^"); | ||
| var firstRev = firstId is null ? null : new GitRevision(firstId); | ||
| ObjectId firstId = Module.RevParse(gitStash.Name + "^"); | ||
| GitRevision firstRev = firstId is null ? null : new GitRevision(firstId); |
There was a problem hiding this comment.
I expected IDE0090 for the assignment and null annotation is obviously not handled
Suggested change
| GitRevision firstRev = firstId is null ? null : new GitRevision(firstId); | |
| GitRevision? firstRev = firstId is null ? null : new(firstId); |
There was a problem hiding this comment.
NRTA not enabled in the UI project, which is tech debt.
| var patchesList = new SortablePatchesList(); | ||
| string text = System.IO.File.ReadAllText(PatchFileNameEdit.Text, GitModule.LosslessEncoding); | ||
| List<Patch> patches = PatchProcessor.CreatePatchesFromString(text, new Lazy<Encoding>(() => Module.FilesEncoding)).ToList(); | ||
| SortablePatchesList patchesList = new SortablePatchesList(); |
There was a problem hiding this comment.
Suggested change
| SortablePatchesList patchesList = new SortablePatchesList(); | |
| SortablePatchesList patchesList = new(); |
| @@ -67,7 +67,9 @@ | |||
|
|
|||
| <!-- Settings --> | |||
| <None Update="Properties\Settings.settings" Generator="SettingsSingleFileGenerator" LastGenOutput="Settings.Designer.cs" /> | |||
| <Compile Update="Properties\Settings.Designer.cs" AutoGen="True" DependentUpon="Settings.settings" /> | |||
| <Compile Update="Properties\Settings.Designer.cs" AutoGen="True" DependentUpon="Settings.settings"> | |||
| <DesignTimeSharedInput>True</DesignTimeSharedInput> | |||
| @@ -49,7 +49,7 @@ public static class GitUIExtensions | |||
| return; | |||
| } | |||
|
|
|||
| var firstId = item.FirstRevision?.ObjectId ?? item.SecondRevision.FirstParentId; | |||
| ObjectId firstId = item.FirstRevision?.ObjectId ?? item.SecondRevision.FirstParentId; | |||
There was a problem hiding this comment.
Suggested change
| ObjectId firstId = item.FirstRevision?.ObjectId ?? item.SecondRevision.FirstParentId; | |
| ObjectId? firstId = item.FirstRevision?.ObjectId ?? item.SecondRevision.FirstParentId; |
|
|
||
| if (file.IsSubmodule && task is not null) | ||
| { | ||
| // Patch already evaluated | ||
| var status = await task; | ||
| GitSubmoduleStatus status = await task; |
There was a problem hiding this comment.
Suggested change
| GitSubmoduleStatus status = await task; | |
| GitSubmoduleStatus? status = await task; |
| if (currentCredentials.UserName == userName && currentCredentials.Password == password) | ||
| { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| var newCredentials = string.IsNullOrWhiteSpace(userName) | ||
| NetworkCredential newCredentials = string.IsNullOrWhiteSpace(userName) |
There was a problem hiding this comment.
Suggested change
| NetworkCredential newCredentials = string.IsNullOrWhiteSpace(userName) | |
| NetworkCredential? newCredentials = string.IsNullOrWhiteSpace(userName) |
|
The nullable annotations should be done anyway, so taking this to avoid any conflicts. Thank you |
|
FYI: Call me naive but I just noticed that VS automatic conversion of all the Solution has done only a very small subset (around 1/4) 😭 😭 😭 |
|
🤣
|
|
There's a diagnostics that should be dialled up in the .editorconfig file.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: done automatically by VS (with 2 or 3 small adaptations -- code indentation and tuples not 100% well handled--)
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.