Plumb service provider to settings pages #11235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
commented
Oct 2, 2023
| @@ -133,10 +133,6 @@ This action will be performed without warning while checking out branch.</source | |||
| <source>Appearance</source> | |||
There was a problem hiding this comment.
Removed the duplicated strings. Essentially, these are being assigned to other controls in the "runtime" constructor; and hence not necessary.
743e7b5 to
44cfa29
Compare
44cfa29 to
ef337ae
Compare
ef337ae to
51be532
Compare
|
Thank you, updated |
51be532 to
333543c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An addendum to #11142. This allows reusing registered instances in the Settings dialog pages.
❗ This change on its own breaks the Windows Forms designer integration for the affected components. The designer integration is fixe by #11249.