Source generate the boilerplate #11249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows Forms designer requires a default constructor to be able to open a form on the design surface. This, however, does not work in situations where some parameters must be set in the constructor (e.g., dependency injection). Previously, we would create a default constructor specifically for the Windows Forms designer integration. However, this implies a lot of unnecessary overhead. Emit the default constructors for the designer integration with source generators.
51c928e to
2f8b36a
Compare
mstv
reviewed
Oct 7, 2023
Comment on lines
+147
to
+154
| #pragma warning disable SA1513 // Closing brace should be followed by blank line | ||
| if (syntaxNode is ClassDeclarationSyntax | ||
| { | ||
| BaseList: BaseListSyntax | ||
| { | ||
| Types.Count: > 0 | ||
| } | ||
| }) |
There was a problem hiding this comment.
@sharwell, StyleCop 1.2.0-beta.435 emits a warning about this.
|
This currently doesn't handle generic forms (e.g., such as Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Forms designer requires a default constructor to be able to open a form on the design surface.
This, however, does not work in situations where some parameters must be set in the constructor (e.g., dependency injection).
Previously, we would create a default constructor specifically for the Windows Forms designer integration. However, this implies a lot of unnecessary overhead.
Emit the default constructors for the designer integration with source generators.
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.