-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Render graph lines with less curves #10637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just looking at the screenshots, and I'm not fond of the new version, sorry.
-1 from me.
|
+1 from me |
We all have likes and dislikes :) And if others like this way better - we'll have it, especially since there's an option to turn it off. |
5e9eee6
to
c801303
Compare
yes, @xnousnow |
79d8f72
to
021e445
Compare
021e445
to
71f0363
Compare
- do not shift direct connection of nodes in neighbor lanes - remove leftover comment
Avoid re-allocations of SegmentDrawer
Avoid re-allocations of SegmentDrawer
Yes, they are. The drawing of the graph is ready for review. Open points (not affecting the graph):
|
71f0363
to
3c71896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitUI/UserControls/RevisionGrid/Graph/Rendering/DiagonalSegmentInfo.cs
Outdated
Show resolved
Hide resolved
We probably should move all graph related settings on their own dedicated page but in a separate PR :) |
by turning into diagonals and unfold one-lane shifts to diagonals
b938e20
to
ebf97ac
Compare
by turning into diagonals and unfold one-lane shifts to diagonals
ebf97ac
to
f6a5f4b
Compare
by turning into diagonals and unfold one-lane shifts to diagonals
f6a5f4b
to
7a7c62f
Compare
by turning into diagonals and unfold one-lane shifts to diagonals
7a7c62f
to
778b6fd
Compare
@mstv Can the Because there is for example the file As a consequence, I can't do anything with master due to error:
|
I am the wrong addressee. I have not pursued the switch to it (and I am not 100% convinced of it. E.g. comments cannot be added in place).
Which kind of problems other than MSYS Git issues? I have never noticed any - and I have rebased these commits many times and have checked them out on a few machines. Though in my checkout, the pathname does not exceed 260 characters. |
I can the see the point of renaming this test, it is long and can cause some issues. [Test]
[TestCase("0:1,4 1:2 2:R,3 3:R 4:R R", "case1")]
[TestCase("0:1,R 1:2,R 2:4,3 3:R 4:5,8 5:6 6:7,R 7:R,R 8:9 9:R R", "case2")]
[TestCase("0:D,1,2,3,4,5,6,B,8,9,7 1:D 2:D 3:E 4:E 5:C 6:C 7:G 8:9 9:A A:B B:C C:F D:R E:F F:R G:H H:R R", "case3")]
[TestCase("0:4 1:3,2 2:6 3:8,B 4:5 5:A,6 6:7 7:8 8:C,R 9:A A:B,R B:R C:R R", "case4")]
public async Task UnfoldOneLaneShiftsToDiagonals(string commitSpecs, string testNameSuffix)
{
AppSettings.StraightenGraphDiagonals.Value = true;
RevisionGraph revisionGraph = CreateGraphTopDown(commitSpecs);
await VerifyGraphLayoutAsync(revisionGraph, $"{MethodBase.GetCurrentMethod().Name}_{testNameSuffix}");
}
private static async Task VerifyGraphLayoutAsync(RevisionGraph revisionGraph, string testNameSuffix)
{
string actualGraph = AsciiGraphFor(revisionGraph).Join("\n");
await Verify(actualGraph)
.UseMethodName(testNameSuffix);
} |
I'm not quite sure I follow, could you please elaborate? |
Comments like the following would benefit from having the ASCII graph in the code - but not in a dedicated file.
Though since I do not expect many further changes to the graph rendering, this does not matter very much. |
While adapting #11594, a file was created which exceeded the 260 characters limit. |
Fixes #5782
Inspired by @spdr870's PoC
Proposed changes
Screenshots
Before / After
Test methodology
Merge strategy
Please do not squash merge this PR!
✒️ I contribute this code under The Developer Certificate of Origin.