CUDA: fix FlashAttention on Turing #13415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing to apologize for, thanks for fixing it! :) Fast fix, fast test - I can confirm it works again after this PR. Thanks for your great work! |
slaren
approved these changes
May 9, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
May 14, 2025
This reverts commit d891942.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 17, 2025
This reverts commit a8e1c88.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 25, 2025
This reverts commit a8e1c88.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 25, 2025
This reverts commit a8e1c88.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 26, 2025
This reverts commit a8e1c88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13306 (comment) .
The problem is that the V data is not being loaded correctly for
nstages == 0(no asynchronous data loading available) and I forgot to test this configuration prior to merging. Sorry!