Skip to content

llama-graph : fix text position for mrope #13159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

llama-graph : fix text position for mrope #13159

merged 3 commits into from
Apr 29, 2025

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Apr 28, 2025

Cont #13138

I misunderstood the original code:

        // TODO: add mrope pos ids somewhere else
        pos.resize(batch.n_tokens * 4);
        std::fill(pos.begin(), pos.end(), 0);
        for (int j = 0; j < batch.n_tokens * 3; j ++) {
            pos[j] = *st_pos_id + (j % batch.n_tokens);
        }
        batch.pos = pos.data();

Which means 3 first dims are the same, and 4th dim is 0, something like this:

1234...1234...1234...0000...

Thanks @mattjcly for spotting this!

@ngxson ngxson requested a review from ggerganov April 28, 2025 22:04
@ngxson ngxson mentioned this pull request Apr 28, 2025
Merged
@mattjcly
Copy link
Contributor

Can confirm this fixes bugs we observed! Thanks @ngxson :)

@ggerganov ggerganov merged commit b6ce743 into ggml-org:master Apr 29, 2025
48 checks passed
alex-spacemit pushed a commit to spacemit-com/llama.cpp that referenced this pull request Jun 22, 2025
@ngxson @alex-spacemit
llama-graph : fix text position for mrope (ggml-org#13159)
dab2031 
* llama-graph : fix text position for mrope

* fix typo

* explicitly set 4th dim in the loop

Change-Id: Iecca261107270aff9d26dd893c1039e355a05eb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngxson @mattjcly @ggerganov