Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Sep 2, 2025

📜 Description

Resolve the symlink path before removing architectures slices.

💡 Motivation and Context

When removing architectures, we were not checking if the file was a symlink.
Fixes: #6046

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link

linear bot commented Sep 2, 2025

@itaybre itaybre marked this pull request as ready for review September 2, 2025 15:06
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for looking into it.

@itaybre itaybre merged commit e446901 into main Sep 2, 2025
99 of 100 checks passed
@itaybre itaybre deleted the itay/cocoa-594-8550-release-has-invalid-framework-structure-on-macos_2 branch September 2, 2025 15:22
itaybre added a commit that referenced this pull request Sep 3, 2025
* fix(ci): Resolve symlink path before removing architectures

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.55.0 release has invalid framework structure on macOS
2 participants