test: selectively activate, always launch ui tests #5467

armcknight · 2025-06-23T18:43:01Z

It seems I got this backwards in #5437, because my local UI test runs didn't work correctly until I switched these.

#skip-changelog

github-actions · 2025-06-23T19:17:40Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1217.65 ms	1246.10 ms	28.45 ms
Size	23.75 KiB	850.73 KiB	826.98 KiB

Revision	Plain	With Sentry	Diff
`f3b8999`	1231.37 ms	1240.04 ms	8.67 ms
`109f689`	1229.08 ms	1248.06 ms	18.98 ms
`e998fd0`	1241.49 ms	1262.63 ms	21.14 ms
`bbe89d8`	1239.18 ms	1250.46 ms	11.28 ms
`742d4b6`	1191.02 ms	1207.08 ms	16.06 ms
`6943de0`	1230.02 ms	1235.32 ms	5.30 ms
`0ecf042`	1228.25 ms	1250.67 ms	22.42 ms
`152437a`	1233.76 ms	1242.93 ms	9.18 ms
`5c115c5`	1249.04 ms	1260.36 ms	11.32 ms
`3eb4e18`	6255.65 ms	6288.63 ms	32.97 ms

Revision	Plain	With Sentry	Diff
`f3b8999`	22.31 KiB	771.06 KiB	748.74 KiB
`109f689`	22.30 KiB	848.30 KiB	826.00 KiB
`e998fd0`	21.58 KiB	414.59 KiB	393.01 KiB
`bbe89d8`	20.76 KiB	435.66 KiB	414.90 KiB
`742d4b6`	21.58 KiB	546.20 KiB	524.62 KiB
`6943de0`	20.76 KiB	393.33 KiB	372.57 KiB
`0ecf042`	21.58 KiB	631.82 KiB	610.24 KiB
`152437a`	21.58 KiB	684.00 KiB	662.42 KiB
`5c115c5`	22.85 KiB	411.72 KiB	388.87 KiB
`3eb4e18`	21.58 KiB	616.14 KiB	594.56 KiB

test: selectively activate, always launch ui tests

ac29b0f

armcknight requested review from philipphofmann, philprime, noahsmartin, trevor-e, itaybre and NicoHinderling as code owners June 23, 2025 18:43

noahsmartin approved these changes Jun 23, 2025

View reviewed changes

itaybre approved these changes Jun 23, 2025

View reviewed changes

armcknight merged commit a7b9459 into main Jun 23, 2025
60 of 61 checks passed

armcknight deleted the armcknight/test/reverse-conditional-launch-activate branch June 23, 2025 19:41

armcknight added a commit that referenced this pull request Jun 23, 2025

test: selectively activate, always launch ui tests (#5467)

7e14de3