test(UI): always wipe all data on disk before starting a new UI test #5436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c319795 | 1256.18 ms | 1266.87 ms | 10.69 ms |
| c021422 | 1199.15 ms | 1222.20 ms | 23.05 ms |
| 94e1968 | 1238.85 ms | 1252.02 ms | 13.17 ms |
| 861d361 | 1227.90 ms | 1231.45 ms | 3.55 ms |
| 32c4446 | 1225.00 ms | 1231.29 ms | 6.29 ms |
| 7b022df | 1220.53 ms | 1227.56 ms | 7.03 ms |
| 25d925a | 1236.73 ms | 1252.86 ms | 16.12 ms |
| 2c603bf | 1226.66 ms | 1243.06 ms | 16.40 ms |
| 18d491a | 1229.78 ms | 1252.67 ms | 22.90 ms |
| 9dbf743 | 1252.10 ms | 1262.10 ms | 10.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
| c021422 | 20.76 KiB | 435.64 KiB | 414.88 KiB |
| 94e1968 | 21.58 KiB | 614.74 KiB | 593.16 KiB |
| 861d361 | 20.76 KiB | 435.65 KiB | 414.89 KiB |
| 32c4446 | 22.84 KiB | 403.24 KiB | 380.39 KiB |
| 7b022df | 22.85 KiB | 412.95 KiB | 390.10 KiB |
| 25d925a | 21.58 KiB | 418.82 KiB | 397.24 KiB |
| 2c603bf | 21.58 KiB | 417.88 KiB | 396.30 KiB |
| 18d491a | 21.58 KiB | 544.87 KiB | 523.29 KiB |
| 9dbf743 | 20.76 KiB | 434.94 KiB | 414.18 KiB |
|
I think I originally had it in |
noahsmartin
reviewed
Jun 20, 2025
noahsmartin
approved these changes
Jun 20, 2025
armcknight
added a commit
that referenced
this pull request
Jun 23, 2025
…5436) * test: always wipe all data on disk before starting a new UI test * do it in BaseUITest.setUp so it only happens once per test case, on the first launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile UI tests all wind up removing launch config files before they end. But if they abnormally exited before being able to do so, then another UI test would wind up running a launch profile.
This change makes sure there is no on-disk data leakage between UI tests in any way, whether that be launch profiles, envelopes, etc.
Noticed this while investigating #5366, but this doesn't fix the root problem of imbalanced bookkeeping mentioned there.
#skip-changelog