fix: Fix xcode 26 #5386
fix: Fix xcode 26 #5386
Conversation
0c52488 to
19b1666
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5386 +/- ##
=============================================
+ Coverage 86.030% 86.075% +0.045%
=============================================
Files 397 397
Lines 34596 34594 -2
Branches 14985 14979 -6
=============================================
+ Hits 29763 29777 +14
+ Misses 4786 4777 -9
+ Partials 47 40 -7
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c45c91c | 1222.90 ms | 1225.75 ms | 2.85 ms |
| e89dc54 | 1220.57 ms | 1233.45 ms | 12.88 ms |
| 024f3db | 1228.08 ms | 1246.55 ms | 18.47 ms |
| c6773e5 | 1222.48 ms | 1240.02 ms | 17.54 ms |
| 0559a8f | 1212.37 ms | 1232.12 ms | 19.76 ms |
| b15521e | 1224.44 ms | 1251.13 ms | 26.68 ms |
| 9798947 | 1224.06 ms | 1238.90 ms | 14.84 ms |
| 6001822 | 1233.31 ms | 1251.64 ms | 18.33 ms |
| 4efc7da | 1235.39 ms | 1256.57 ms | 21.18 ms |
| 8fb1a4a | 1225.73 ms | 1251.48 ms | 25.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c45c91c | 21.58 KiB | 714.29 KiB | 692.71 KiB |
| e89dc54 | 22.85 KiB | 412.60 KiB | 389.75 KiB |
| 024f3db | 21.90 KiB | 725.67 KiB | 703.76 KiB |
| c6773e5 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
| 0559a8f | 21.58 KiB | 419.81 KiB | 398.22 KiB |
| b15521e | 21.58 KiB | 573.18 KiB | 551.60 KiB |
| 9798947 | 22.31 KiB | 821.95 KiB | 799.64 KiB |
| 6001822 | 22.85 KiB | 410.99 KiB | 388.14 KiB |
| 4efc7da | 22.31 KiB | 765.80 KiB | 743.48 KiB |
| 8fb1a4a | 21.90 KiB | 727.76 KiB | 705.86 KiB |
There was a problem hiding this comment.
We've touched the sentrycrashmc_contextSize a couple of times in recent weeks/months. It would be great to have a comment in the code to share additional context why this is done using a macro instead of a const int, so we when revisiting it again we do not have to find this PR first.
Leaving this to you.
There was a problem hiding this comment.
Personally I don't think this warrants a comment in the code. If people are interested in how the code has evolved they can find their way back to this PR with git blame.
@noahsmartin I originally asked you to verify a crash before and after this change but looking again I don't think that is really even necessary.
19b1666 to
12264b3
Compare
📜 Description
Fix for Xcode 26
💡 Motivation and Context
Fixes this error in Xcode 26:
💚 How did you test it?
Build with xcode
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.