Skip to content

refactor(session-replay): Add separate files and missing type prefix #5343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 13, 2025
Merged

refactor(session-replay): Add separate files and missing type prefix #5343

merged 17 commits into from
Jun 13, 2025

Conversation

philprime
Copy link
Member

@philprime philprime commented Jun 3, 2025 •
edited
Loading

  • Refactors types into separate files
  • Adds missing prefix Sentry for crash detection.
  • Renamed image to maskedViewImage in multiple occurences to indicate what kind of image it is.

Blocked by:

These changes are derived from #5073

#skip-changelog

@philprime philprime self-assigned this Jun 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.96 ms 1253.29 ms 31.33 ms
Size 23.75 KiB 847.17 KiB 823.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3a6495e 1227.61 ms 1239.22 ms 11.60 ms
ee00d2b 1228.35 ms 1250.04 ms 21.69 ms
4afae53 1217.65 ms 1229.27 ms 11.62 ms
89491ad 1222.12 ms 1231.96 ms 9.83 ms
5d6ce0e 1206.72 ms 1228.67 ms 21.95 ms
2124551 1265.50 ms 1276.44 ms 10.94 ms
2d2068d 1238.02 ms 1249.90 ms 11.88 ms
ecd9ecd 1191.76 ms 1216.92 ms 25.16 ms
3cba0e8 1236.29 ms 1271.21 ms 34.92 ms
4597906 1228.37 ms 1242.29 ms 13.92 ms

App size

Revision Plain With Sentry Diff
3a6495e 21.58 KiB 422.66 KiB 401.08 KiB
ee00d2b 23.76 KiB 821.43 KiB 797.67 KiB
4afae53 22.84 KiB 402.08 KiB 379.24 KiB
89491ad 21.58 KiB 417.89 KiB 396.30 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
2124551 22.85 KiB 411.69 KiB 388.84 KiB
2d2068d 21.58 KiB 729.47 KiB 707.89 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
3cba0e8 22.84 KiB 403.19 KiB 380.34 KiB
4597906 21.58 KiB 678.19 KiB 656.61 KiB

Previous results on branch: philprime/sr-refactoring

Startup times

Revision Plain With Sentry Diff
a6e06da 1225.50 ms 1246.44 ms 20.94 ms
9f56949 1241.08 ms 1267.04 ms 25.96 ms

App size

Revision Plain With Sentry Diff
a6e06da 23.76 KiB 837.92 KiB 814.16 KiB
9f56949 23.75 KiB 847.17 KiB 823.43 KiB

@philprime philprime marked this pull request as ready for review June 3, 2025 14:17
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.91919% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.046%. Comparing base (c5d844f) to head (a4f7ae4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ore/Tools/ViewCapture/SentryRedactViewHelper.swift 72.000% 7 Missing ⚠️
...Core/Tools/ViewCapture/SentryUIRedactBuilder.swift 97.500% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5343       +/-   ##
=============================================
+ Coverage   86.043%   86.046%   +0.002%     
=============================================
  Files          397       399        +2     
  Lines        34593     34621       +28     
  Branches     14975     14976        +1     
=============================================
+ Hits         29765     29790       +25     
- Misses        4786      4789        +3     
  Partials        42        42
Files with missing lines Coverage Δ
.../Tools/ViewCapture/SentryDefaultMaskRenderer.swift 100.000% <100.000%> (ø)
.../Core/Tools/ViewCapture/SentryMaskRendererV2.swift 100.000% <100.000%> (ø)
...ft/Core/Tools/ViewCapture/SentryRedactRegion.swift 100.000% <100.000%> (ø)
...ore/Tools/ViewCapture/SentryViewPhotographer.swift 73.913% <100.000%> (+0.579%) ⬆️
...ssionReplay/Preview/SentryMaskingPreviewView.swift 86.274% <100.000%> (ø)
...egrations/SessionReplay/SentryOnDemandReplay.swift 89.795% <100.000%> (-1.155%) ⬇️
...rations/SessionReplay/SentryReplayVideoMaker.swift 100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentrySessionReplay.swift 90.553% <100.000%> (ø)
...Core/Tools/ViewCapture/SentryUIRedactBuilder.swift 93.750% <97.500%> (ø)
...ore/Tools/ViewCapture/SentryRedactViewHelper.swift 72.000% <72.000%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d844f...a4f7ae4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

armcknight
armcknight approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple small things you can do if you like.

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Jun 13, 2025
@philprime philprime merged commit 9ed28d6 into main Jun 13, 2025
128 of 131 checks passed
@philprime philprime deleted the philprime/sr-refactoring branch June 13, 2025 09:24
philprime added a commit that referenced this pull request Jun 13, 2025
@philprime @philipphofmann @armcknight
refactor(session-replay): Add separate files and missing type prefix (#…
b98c4d1 
…5343)

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armcknight armcknight armcknight approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@noahsmartin noahsmartin Awaiting requested review from noahsmartin noahsmartin is a code owner

@trevor-e trevor-e Awaiting requested review from trevor-e

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

@NicoHinderling NicoHinderling Awaiting requested review from NicoHinderling

Assignees

@philprime philprime

Labels
Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philprime @armcknight @philipphofmann