Skip to content

feat(entitlements): Add entitlements to plan response (read-only) #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

feat(entitlements): Add entitlements to plan response (read-only) #3960

merged 1 commit into from
Jul 10, 2025

Conversation

julienbourdeau
Copy link
Contributor

Entitlements are returned when you retrieve a plan from the API.
Notice that you cannot edit/create entitlements via the plans/:code endpoints, you must use plans/:code/entitlements for now.

@julienbourdeau julienbourdeau self-assigned this Jul 10, 2025
groyoh
groyoh approved these changes Jul 10, 2025
View reviewed changes
@julienbourdeau julienbourdeau force-pushed the ent/serialize-in-plan branch from cb5fcae to 76de689 Compare July 10, 2025 13:32
groyoh
groyoh reviewed Jul 10, 2025
View reviewed changes
@julienbourdeau julienbourdeau force-pushed the ent/serialize-in-plan branch from 76de689 to b21c66b Compare July 10, 2025 14:16
@julienbourdeau
Copy link
Contributor Author

Thank you @groyoh for the careful review! 🙏

@julienbourdeau julienbourdeau merged commit 968fbaf into main Jul 10, 2025
14 checks passed
@julienbourdeau julienbourdeau deleted the ent/serialize-in-plan branch July 10, 2025 14:22
@julienbourdeau julienbourdeau mentioned this pull request Jul 10, 2025
Merged
julienbourdeau added a commit that referenced this pull request Jul 11, 2025
@julienbourdeau
fix(plans): better plan reload (#3969)
a207410 
Fix not so nice implementation added here
#3960
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
@julienbourdeau @diegocharles
feat(entitlements): Add entitlements to plan response (read-only) (#3960
0f01834 
)

Entitlements are returned when you retrieve a plan from the API.
Notice that you cannot edit/create entitlements via the `plans/:code`
endpoints, you must use `plans/:code/entitlements` for now.
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
@julienbourdeau @diegocharles
fix(plans): better plan reload (#3969)
a770ea0 
Fix not so nice implementation added here
#3960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groyoh groyoh groyoh approved these changes

Assignees

@julienbourdeau julienbourdeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienbourdeau @groyoh