chore(plans): Use update_all to flag plan children for deletion #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
approved these changes
Jul 10, 2025
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
### Expose `pending_deletion`
When you delete a plan via the API, you get it in the response but
nothing shows that it is deleted or about to be deleted.
Because deletion is async, getting this plan from the API will work as
if nothing happened until the job is processed.
Need openapi and clients update.
### use `update_all` instead of `.each{ it.update! }`
A plan can have maaany children and since we're not calling a service or
relying on any model callbacks, I believe it's best to flag them all at
once.
Introduced here:
69a8470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
pending_deletionWhen you delete a plan via the API, you get it in the response but nothing shows that it is deleted or about to be deleted.
Because deletion is async, getting this plan from the API will work as if nothing happened until the job is processed.
Need openapi and clients update.
use
update_allinstead of.each{ it.update! }A plan can have maaany children and since we're not calling a service or relying on any model callbacks, I believe it's best to flag them all at once.
Introduced here: 69a8470