misc(subscription): Ensure Subscriptions::UpdateService uses perform_after_commit
#3950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
approved these changes
Jul 8, 2025
36e3826 to
de5c8e6
Compare
…rm_after_commit`
7a46c92 to
13dd83d
Compare
diegocharles
pushed a commit
that referenced
this pull request
Jul 11, 2025
…rm_after_commit` (#3950) ## Context `Subscriptions::UpdateService` currently do not ensure that jobs are scheduled after commit. This has no impact right now as the service is not called in a transaction anywhere but it will be the case soon. ## Description This commit ensures the jobs are scheduled after commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Subscriptions::UpdateServicecurrently do not ensure that jobs are scheduled after commit. This has no impact right now as the service is not called in a transaction anywhere but it will be the case soon.Description
This PR ensures the jobs are scheduled after commit.