Skip to content

Conversation

ivannovosad
Copy link
Contributor

Context

Filtering by is_customer_tin_empty which filters by existent or non-existent customer tax_identification_number was missing.

Description

This PR adds the missing filter to invoice collection.

Copy link
Contributor

@groyoh groyoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a test for this ?

@ivannovosad
Copy link
Contributor Author

👍 @groyoh I added specs

@ivannovosad ivannovosad merged commit 5d1641c into main Jul 8, 2025
14 checks passed
@ivannovosad ivannovosad deleted the fix-invoice-collection-filter branch July 8, 2025 11:03
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
## Context

Filtering by `is_customer_tin_empty` which filters by existent or
non-existent customer `tax_identification_number` was missing.

## Description

This PR adds the missing filter to invoice collection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants